Optimized incoming bytes queue. Release lock asap. #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ush the data into the queue.
|
@IgorMilavec @WojciechNagorski This can be closed as ShellStream has changed too much since this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current incoming queue keeps the bytes. It is expensive operation since the OnDataReceived event gets the data in form of byte[]. If we read the bytes from array and enqueue them into incoming queue, it will hold the lock on incoming queue for long. This in-turn blocks the read operation from the incoming queue. Hence, the change from Queue -> Queue<byte[]> improves performance.