ScpClient does not properly quote paths

[danvac]

scpClient.Download does not work on MikroTik 5.26
I am getting exception Renci.SshNet.Common.ScpException: scp error: /"file.backup": no such file or directory!

When tested scp from Fedora box, it worked without problems.
Please provide info what informations you will need for fixing (debugging).

[drieseng]

Do you happen to have a device that I could test against?

[danvac]

Device is prepared. Is there any private way to tell you credentials and connection info?
@drieseng

[drieseng]

You should be able to contact me through my profile.

[drieseng]

What (remote) path did you specify when you got the error you mentioned above?
Can you share the code fragment in question?

[danvac]

downloads.Add("batchtelnet.rsc");
...
foreach (string download in downloads) {
...
                                    try
                                    {
                                        scp.Download(download, File.Create(inputfilepath));
                                        System.Threading.Thread.Sleep(scpDelay);
                                    }
                                    catch (Renci.SshNet.Common.ScpException ex)
                                    {
                                        _log.log(String.Format("{0}: {1}", ex.GetType().ToString(), ex.Message));
                                    }
                                    catch (Exception ex)
                                    {
                                        _log.log(String.Format("{0}: {1}", ex.GetType().ToString(), ex.Message));
                                    }

[drieseng]

Was able to reproduce the issue.
There's a similar issue with Upload(...).

[drieseng]

I've fixed this issue (and a few related ones) locally.
I still want to add some tests and verify whether these fixes also resolve #108.

[drieseng]

The problem here was that we were using a over-simplified quoting mechanism (meaning surround any path with double quotes). Apparently MikroTik does not handle (double) quoted paths.

I've now updated our implementation to apply the following scheme:

• embed a single-quotes in quotes (' => "'")
• escape exclamation points with a backslash, and do not embed this in single-quotes (! => !)
• embed all other characters in single-quotes (a => 'a')

This should work with all shells.

[drieseng]

Enclosing characters in single quotes should preserve the literal value of each character within the single-quotes. However, I've just learned that MikroTik instead adds the single quotes to the actual file or directory name :(

This is not the first quirk I've seen in the MikroTik SCP implementation.
Do you happen to have contacts at MikroTik to discuss these with?

Meanwhile, I'll consider revisit our quoting scheme...