Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

Upgrade eslint and markdownlint-cli to latest available version.#21

Merged
xydesa merged 3 commits into
sscpac:masterfrom
xydesa:upgrade-npm-deps
Jan 27, 2021
Merged

Upgrade eslint and markdownlint-cli to latest available version.#21
xydesa merged 3 commits into
sscpac:masterfrom
xydesa:upgrade-npm-deps

Conversation

@xydesa

@xydesa xydesa commented Jan 25, 2021

Copy link
Copy Markdown
Collaborator

Signed-off-by: Alexander Xydes alexander.xydes@navy.mil

Signed-off-by: Alexander Xydes <alexander.xydes@navy.mil>
@xydesa xydesa requested review from denewiler and removed request for denewiler January 25, 2021 20:20
…ent directory used for linting because eslint no longer supports global installs.

Signed-off-by: Alexander Xydes <alexander.xydes@navy.mil>
@xydesa

xydesa commented Jan 27, 2021

Copy link
Copy Markdown
Collaborator Author

Based on this stackoverflow post, and that newer versions of eslint do not support global installs (see links below) I changed the install location for most npm packages to the parent directory of the CWD in github actions.

https://eslint.org/docs/user-guide/migrating-to-6.0.0#package-loading-simplification
eslint/rfcs#47
eslint/eslint#13685

@xydesa xydesa requested a review from denewiler January 27, 2021 18:56
…ies.

Signed-off-by: Alexander Xydes <alexander.xydes@navy.mil>
@xydesa xydesa merged commit e7a1c75 into sscpac:master Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants