-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Labels
bugSomething isn't workingSomething isn't workingformatIssues related to format analyzerIssues related to format analyzersmallSmall sizeSmall size
Description
cf further discussion in this issue (that happened before this edition, cf original issue text): Currently, we list the repositories that we use in the quality report in a CSV file that has 3 columns: url
, to
and from
. Only url
and from
are used. We should therefore remove the to
column and rename from
to commit_hash
.
Original issue text
Excerpt from quality_report_repos.csv
:
url,to,from
https://github.com/reduxjs/redux,902484ed735d38aec06683c847810a7218d8dba2,b307091af4d7e846d9e5f080fb81caf4a8b4aab1
In that repo, one of the files we make predictions for (and actually get errors from) is examples/todos-flow/src/__tests__/reducers/visibilityFilter.test.js
.
It is present in the from
revision:
$ git show b307091af4d7e846d9e5f080fb81caf4a8b4aab1:examples/todos-flow/src/__tests__/reducers/visibilityFilter.test.js
// @flow
import { setVisibilityFilter } from '../../actions/visibilityFilter';
import visibilityFilter from '../../reducers/visibilityFilter';
describe('visibilityFilter', () => {
it('should handle initial state', () => {
expect(visibilityFilter(undefined, { type: '@@INIT' })).toEqual('SHOW_ALL');
});
it('should handle SET_VISIBILITY_FILTER', () => {
expect(
visibilityFilter(undefined, setVisibilityFilter('SHOW_ACTIVE'))
).toEqual('SHOW_ACTIVE');
});
});
but not in the to
revision:
$ git show 902484ed735d38aec06683c847810a7218d8dba2:examples/todos-flow/src/__tests__/reducers/visibilityFilter.test.js
fatal: Path 'examples/todos-flow/src/__tests__/reducers/visibilityFilter.test.js' does not exist in '902484ed735d38aec06683c847810a7218d8dba2'
Therefore we should not make predictions for it.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingformatIssues related to format analyzerIssues related to format analyzersmallSmall sizeSmall size