Skip to content

Add progress charts #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2019
Merged

Add progress charts #148

merged 3 commits into from
Jun 21, 2019

Conversation

se7entyse7en
Copy link
Contributor

Closes #133.

This adds progress charts fro ghsync and gitcollector.

Screenshot 2019-06-21 at 16 09 28

@se7entyse7en
Add metadata tables
c4737e1 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@smacker
Copy link
Contributor

smacker commented Jun 21, 2019

does it contain cache timeout 0 already or not?

@se7entyse7en
Copy link
Contributor Author

@smacker not yet, and I've just realized that for some reason the id changed from 2 to 3 😕.

@se7entyse7en
Copy link
Contributor Author

@smacker I've set cache_timeout: 0 and also changed the title of the welcome dashboard as @carlosms asked.

smacker
smacker reviewed Jun 21, 2019
View reviewed changes
srcd/dashboards/gitbase/welcome.json
@@ -10,7 +10,7 @@
"created_by_fk": null,
"json_metadata": "{\"filter_immune_slices\": [], \"timed_refresh_immune_slices\": [], \"filter_immune_slice_fields\": {}, \"expanded_slices\": {}, \"default_filters\": \"{}\", \"remote_id\": 1, \"import_time\": 1560871295, \"refresh_frequency\": 0}",
"description": null,
"dashboard_title": "Welcome",
"dashboard_title": "Overview",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still "welcome" few lines above: "meta\": {\"text\": \"Welcome\"}, \"type\": \"HEADER\"}

@smacker
Copy link
Contributor

smacker commented Jun 21, 2019

Wait, I'll test it.

@se7entyse7en
Copy link
Contributor Author

@smacker I force-pushed the latest changes. Fixed the title as you said and set timeout to 1. Now refreshing the page upates the chart.

smacker
smacker suggested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@smacker smacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It opens wrong dashboard by default now

@smacker
Copy link
Contributor

smacker commented Jun 21, 2019

Oh. Not just a wrong one. There is no welcome dashboard at all anymore:
Screenshot 2019-06-21 at 17 48 32

@se7entyse7en
Copy link
Contributor Author

@smacker yup, sorry I forgot to mention in the last push I fixed the id of the dashboard. For some reason when I exported it the id changed 🤷‍♂

@smacker
Copy link
Contributor

smacker commented Jun 21, 2019

@se7entyse7en what do you mean? I have the latest changes:

smacker in ~/Work/sourced-ui on progress-chart [?]
$ git pull
Already up to date.
Current branch progress-chart is up to date.

@se7entyse7en
Modify placeholder.json
9ba706e 
Signed-off-by: Lou Marvin Caraig <[email protected]>
@se7entyse7en
Change welcome dashboard title
62a83a3 
Signed-off-by: Lou Marvin Caraig <[email protected]>
smacker
smacker approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@smacker smacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm it works after changing not only id but remote_id too.

@marnovo
Copy link
Member

marnovo commented Jun 21, 2019

Can I consider this the latest version with progress bars and use it as reference?

@se7entyse7en se7entyse7en merged commit c378b64 into master Jun 21, 2019
@se7entyse7en se7entyse7en deleted the progress-chart branch June 21, 2019 19:23
@carlosms carlosms mentioned this pull request Jun 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpordomingo dpordomingo Awaiting requested review from dpordomingo

2 more reviewers

@smacker smacker smacker approved these changes

@carlosms carlosms carlosms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dashboard for gitcollector and ghsync progress
4 participants
@se7entyse7en @smacker @marnovo @carlosms