Merged
Conversation
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
| func mergeMatrices(m1, m2 DenseHistory, granularity1, sampling1, granularity2, sampling2 int, | ||
| c1, c2 *core.CommonAnalysisResult) DenseHistory { | ||
| commonMerged := *c1 | ||
| commonMerged := c1.Copy() |
There was a problem hiding this comment.
Is c1 at some point written in parallel? Because if it is, you would still need to wrap the reading and writing in a mutex.
Collaborator
Author
There was a problem hiding this comment.
There is a mutex at the higher level for the rest of the code. This piece expects an immutable object, and I forgot about the mutable maps.
So answering the question: no, it is not, and not intended to be possible.
erizocosmico
approved these changes
Jan 25, 2019
dmytrogajewski
pushed a commit
to dmytrogajewski/hercules
that referenced
this pull request
Jul 28, 2025
Fix common result merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadim Markovtsev vadim@sourced.tech