This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Removed pilosa-dependent files from Windows compilation #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I submitted an issue to Pilosa regarding Windows not building on their project, and it was stated that there is no plan to support Windows natively. |
Signed-off-by: Daylon Wilkins <[email protected]>
Hydrocharged
force-pushed
the
windows-support
branch
from
6c33554 to
010fe49
Compare
erizocosmico
suggested changes
Sep 6, 2019
…ADME Signed-off-by: Daylon Wilkins <[email protected]>
Hydrocharged
force-pushed
the
windows-support
branch
from
317155d to
5931c40
Compare
erizocosmico
approved these changes
Sep 9, 2019
ajnavarro
approved these changes
Sep 9, 2019
agarciamontoro
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pilosa makes use of the following call which does not work on Windows:
https://github.com/pilosa/pilosa/blob/bc9747cc0f19702d9753de7ea9375d8311dfc706/syswrap/mmap.go#L53
This causes any files that refer to Pilosa to fail compilation, which in turn causes builds for this project to also fail.