This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for: src-d/gitbase/issues/824 (the missing part is using it on the columns / types of gitbase where superset expects varchars).
This adds
VarChar
as an specific type. As happens withArray
, it's a parametrized type that will be returned by a function with a specific length. It is convertible from and toText
andstring
and will return true forIsText
so it should work for all functions usingText
.There is a "TO-DO" comment I added in the
NewLiteral
function, any suggestion is welcomed: