Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Varchar type #775

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Varchar type #775

merged 2 commits into from
Jul 3, 2019

Conversation

juanjux
Copy link
Contributor

@juanjux juanjux commented Jun 28, 2019

Part of the fix for: src-d/gitbase/issues/824 (the missing part is using it on the columns / types of gitbase where superset expects varchars).

This adds VarChar as an specific type. As happens with Array, it's a parametrized type that will be returned by a function with a specific length. It is convertible from and to Text and string and will return true for IsText so it should work for all functions using Text.

There is a "TO-DO" comment I added in the NewLiteral function, any suggestion is welcomed:

	// TODO(juanjux): we should probably check here if the type is sql.VarChar and the
	// Capacity of the Type and the length of the value, but this can't return an error

Added note about VarChar in MysqlTypeToType

Signed-off-by: Juanjo Alvarez <[email protected]>
@ajnavarro ajnavarro merged commit 5c04d05 into src-d:master Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants