This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/expression: relaxed json_extract #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
Apr 18, 2019
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| result[i], _ = c.Lookup(doc) // err ignored |
There was a problem hiding this comment.
Maybe it's worth it to give some info to the user in this case using Warn:
ctx.Warn(0, err.Error())There was a problem hiding this comment.
I believe that will be noise, because can be very common, since for example in my LOC if the language is not supported will be empty and then a warm
ajnavarro
reviewed
Apr 18, 2019
Signed-off-by: Máximo Cuadros <[email protected]>
ajnavarro
approved these changes
Apr 18, 2019
ajnavarro
suggested changes
Apr 18, 2019
juanjux
approved these changes
Apr 19, 2019
erizocosmico
approved these changes
Apr 22, 2019
ajnavarro
approved these changes
Apr 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation a query stops to be executed when one of the rows is empty or doesn't fit the json path expression, this PR allows any failure on the query to a value, but fails on a wrong expression.