allow usage of multiple gopaths #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serabe
suggested changes
Apr 26, 2017
.travis.yml
Outdated
|
|
||
| env: | ||
| - DBNAME=kallax_test DBUSER=postgres DBPASS='' | ||
| - GOPATH=$GOPATH:/tmp/whatever |
| path = filepath.ToSlash(path) | ||
| return strings.Replace(path, importPath, "", -1) | ||
| for _, p := range parseutil.DefaultGoPath { | ||
| p = filepath.ToSlash(p + "/src/") |
There was a problem hiding this comment.
Join will strip the last "/", which we want to replace later.
Closed
erizocosmico
force-pushed
the
fix/gopath
branch
from
738a73d to
c8fb010
Compare
|
Amended with the change, @Serabe |
erizocosmico
force-pushed
the
fix/gopath
branch
from
c8fb010 to
b0b0b26
Compare
Serabe
approved these changes
Apr 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 80.39% 80.29% -0.11%
==========================================
Files 15 15
Lines 2790 2796 +6
==========================================
+ Hits 2243 2245 +2
- Misses 375 378 +3
- Partials 172 173 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123
Requires src-d/go-parse-utils#8