Debug() gets lost when saving with relations due to transactions.

[nawuko]

If we currently create a new store with .Debug() we don't get any output when saving schemas with relations since transactions take place in a newly constructed store that no longer inherits our debug proxy.

Following does occur user.Save -> user.Insert -> Store.Transaction() -> newStoreWithTransaction [at this point our debug proxy gets lost]

If i'm not mistaken its currently not possible to have .Debug() logs for anything that happens during a Store.Transaction

--
Sorry for my broken english, if you have problems to understand the issue due to the poor description feel free to ask any questions.

[nadiamoe]

When a new store is created with newStoreWithTransaction, it doesn't inherit the previous store proxies, so it the debug is effectively lost.

I can confirm this as unintended behaviour. Should be easy to fix, expect it to arrive in a few days (I'm currently a bit busy).

[nawuko]

Awesome, thank you for looking into the issue and sorry again for being a bit unclear in the issue description.

[nadiamoe]

No problem at all!

As a workaround, try to re-obtain a debugging instance inside of the transaction callback function:

store.Transaction(func(s *UserStore) error {
        s = s.Debug() // Re-obtain debug-enabled store
        if err := s.Insert(user1); err != nil {
                return err
        }

        return s.Insert(user2)
})

Please tell me if this works for you.

[nawuko]

This indeed works like a charm.

Also its better practise to wrap this stuff ourself in a transaction in my eyes, even tho kallax would to this on its own, its a bit easier to see what really happens afterwards.

Only problem with this is that i need an ugly if statement in every transaction to check if i want to create a .Debug store (since we don't want to log queries in production).

Thanks for the awesome feedback

[nadiamoe]

Ideally .Debug() is only for, well, debug purposes. Kallax should be assumed to generate valid SQL, so it's there to help with type translations, scans, and other delicate parts of row mapping.

Anyway, I'll write a fix for this, since it's certainly intuitive that transactions issued on a debug store are debugged as well.

[nadiamoe]

Fixed. This will close automatically when I merge the changes into master.

[nawuko]

Awesome, thank you 👍