This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Fix pktline api #89
Merged
Fix pktline api #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old pktline API only had one method: New, that receives the payloads and return the new PktLine, that was an io.Reader. This means you have to prepare the contents beforehand, in a [][]byte and then call the ctor to build the pktlines. Now, the construction of the pktlines and the method to add payloads are separated: New() // creates an empty PktLines AddFlush() Add(pp ...[]byte) AddString(pp ...string) and a PktLines has a public member R, which is the io.Reader of the pktlines added.
|
IMHO the structure can be Packfiles, but the name of the package should be the name of the format. |
|
Agree @mcuadros, will do that. |
|
I will also change the public attribute to a Reader method. |
dpordomingo
reviewed
Oct 19, 2016
| // New returns an empty PktLines (with no payloads) ready to be used. | ||
| func New() *PktLines { | ||
| return &PktLines{ | ||
| R: io.MultiReader([]io.Reader{}...), |
There was a problem hiding this comment.
maybe better if it would be something like p.Reader()
There was a problem hiding this comment.
You are right, will do!
|
Package name changed to R attribute removed, now PktLines are Readers themselves. PTAL. |
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* Change pktline API so you can add payloads The old pktline API only had one method: New, that receives the payloads and return the new PktLine, that was an io.Reader. This means you have to prepare the contents beforehand, in a [][]byte and then call the ctor to build the pktlines. Now, the construction of the pktlines and the method to add payloads are separated: New() // creates an empty PktLines AddFlush() Add(pp ...[]byte) AddString(pp ...string) and a PktLines has a public member R, which is the io.Reader of the pktlines added. * metalinter * change package name from pktlines to pktline * change package name from pktlines to pktline for true * make pktlines a reader instead of have a reader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old pktline API only had one method: New, that receives the
payloads and return the new PktLine, that was an io.Reader. This means
you have to prepare the contents beforehand, in a [][]byte or a []string and then
call the ctor to build the pktlines:
Now, the construction of the pktlines and the methods to add payloads and flush-pkts are
separated and the reader is an attribute:
I have also change the name of the package to its plural version: pktlines, as the package purpose is to handle several pktlines together, not just one.