This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: format/packfile, fix panic retrieving object hash. #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the original data is not saved before it is cleaned
and forces a panic when it's needed.
The change adds ObjectToPack.CleanOriginal to be used to clean original
object instead of:
object.Original = nil
Now when the Original data is freed because it's no longer in the pack
window a SetOriginal call is done to make sure that Size, Hash and Size
data is not lost.
Signed-off-by: Javi Fontan <[email protected]>
erizocosmico
approved these changes
Feb 9, 2018
ajnavarro
suggested changes
Feb 9, 2018
| @@ -231,7 +231,8 @@ func (dw *deltaSelector) walk( | |||
| delete(indexMap, obj.Hash()) | |||
|
|
|||
| if obj.IsDelta() { | |||
| obj.Original = nil | |||
| obj.SetOriginal(obj.Original) | |||
| obj.CleanOriginal() | |||
There was a problem hiding this comment.
this is a little bit strange, maybe is worth it to add a method that just add the original metadata to the objectToPack, something like obj.SetOriginalMetadata(obj.Original)
There was a problem hiding this comment.
I've adede a SaveOriginalMetadata function. It uses current Original object.
Signed-off-by: Javi Fontan <[email protected]>
ajnavarro
approved these changes
Feb 13, 2018
jfontan
added a commit
to jfontan/borges
that referenced
this pull request
Mar 28, 2018
It fixes some panics retrieving object hashes src-d/go-git#744 Signed-off-by: Javi Fontan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the original data is not saved before it is cleaned and forces a panic when it's retrieved.
The change adds
ObjectToPack.CleanOriginalto be used to clean original object instead of:Now when the Original data is freed because it's no longer in the pack window a
SetOriginalcall is done to make sure that Size, Hash and Size data is not lost.Fixes src-d/borges#229