This repository was archived by the owner on Sep 11, 2020. It is now read-only.
storage: Add object type hint parameter to ObjectStorage.Get. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 66.17% (diff: 76.66%)@@ v4 #69 diff @@
==========================================
Files 53 53
Lines 3050 3013 -37
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2084 1994 -90
- Misses 738 805 +67
+ Partials 228 214 -14
|
| @@ -49,6 +49,9 @@ const ( | |||
| TagObject ObjectType = 4 | |||
| OFSDeltaObject ObjectType = 6 | |||
| REFDeltaObject ObjectType = 7 | |||
|
|
|||
| // Used as a placeholder to request an object of any time. | |||
There was a problem hiding this comment.
I'm thinking it will be nice to explain that all these types and their associated numbers are from the official git specification, except for InvalidObject and AnyObject, which are object types of our own invention, that will never be found inside an official git repository.
|
LGTM, looking even better if #69 (comment) is fixed. In any case, you can merge whenever you want. |
Some storage backends can optimize object lookup if they get the object type that is expected. So we the signature of the Get method is now Get(Hash, ObjectType). Added generic tests for storage backends.
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
Some storage backends can optimize object lookup if they get the object type that is expected. So we the signature of the Get method is now Get(Hash, ObjectType). Added generic tests for storage backends.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some storage backends can optimize object lookup if they get
the object type that is expected. So we the signature of the Get
method is now Get(Hash, ObjectType).