plumbing/transport: export Transport impls #437
Conversation
| return &SCPEndpoint{ | ||
| Username: m[1], | ||
| Hostname: m[2], | ||
| Pathname: m[3], |
There was a problem hiding this comment.
can you keep Pathname as Path?
There was a problem hiding this comment.
I cannot, for the same reason as I needed to rename the other fields -- they conflict with the method names.
|
Ping? |
|
@taralx sorry about the delay, I am ok exporting the types, but you don't need to export the fields, since they can be accessed by the functions. This works for you? |
|
@mcuadros In that case there's no advantage in exporting them, since they cannot be constructed. |
|
Can you explain your use case? Maybe you can create your own endpoint |
|
It's #424 as specified in the commit message. If you don't want to export the fields of the others, that's fine by me -- I just don't know that it's worth exporting their types either if they're not constructible. |
mcuadros
force-pushed
the
master
branch
8 times, most recently
from
336a7d1 to
319bac9
Compare
Fixes #424