Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Fix issue 275 (edited) #276

Merged
merged 3 commits into from
Feb 22, 2017
Merged

Fix issue 275 (edited) #276

merged 3 commits into from
Feb 22, 2017

Conversation

alcortesm
Copy link
Contributor

@alcortesm alcortesm commented Feb 20, 2017

Fix #275 .

It was not possible to write a test for this issue as the original fsnoder didn't support filenames with length > 1. Therefore this patch has 3 commits:

  1. add support for long filenames in fsnoder.
  2. add a test case for the issue using the new long filenames from step 1.
  3. fix the issue by comparing paths level by level instead of lexigographically over the whole path.

@alcortesm
Copy link
Contributor Author

rebased.

@alcortesm alcortesm changed the title Fix issue 275 Fix issue 275 (edited) Feb 22, 2017
Some tests of the difftree, like the ones we want to do to solve
#275 needs long file names,
before this patch fsnoders could only have 1 char names.
@codecov-io
Copy link

Codecov Report

Merging #276 into master will increase coverage by 0.25%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   76.62%   76.88%   +0.25%     
==========================================
  Files         116      116              
  Lines        7860     7886      +26     
==========================================
+ Hits         6023     6063      +40     
+ Misses       1183     1169      -14     
  Partials      654      654
Impacted Files Coverage Δ
utils/merkletrie/noder/path.go 100% <100%> (+100%)
utils/merkletrie/difftree.go 43.15% <100%> (ø)
utils/merkletrie/internal/fsnoder/new.go 94.73% <89.28%> (-5.27%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79bc09...4251177. Read the comment docs.

@alcortesm alcortesm merged commit b5da4e9 into src-d:master Feb 22, 2017
@alcortesm alcortesm deleted the fix-issue-275 branch February 22, 2017 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merkletrie.Difftree return wrong results for directories named after files without extension.
4 participants