Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

worktree: allow manual ignore patterns when no .gitignore is available #1070

Merged
merged 2 commits into from
Mar 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion worktree_status.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,16 @@ func (w *Worktree) diffStagingWithWorktree(reverse bool) (merkletrie.Changes, er

func (w *Worktree) excludeIgnoredChanges(changes merkletrie.Changes) merkletrie.Changes {
patterns, err := gitignore.ReadPatterns(w.Filesystem, nil)
if err != nil || len(patterns) == 0 {
if err != nil {
return changes
}

patterns = append(patterns, w.Excludes...)

if len(patterns) == 0 {
return changes
}

m := gitignore.NewMatcher(patterns)

var res merkletrie.Changes
Expand Down
28 changes: 28 additions & 0 deletions worktree_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1129,6 +1129,34 @@ func (s *WorktreeSuite) TestIgnored(c *C) {
c.Assert(file.Worktree, Equals, Untracked)
}

func (s *WorktreeSuite) TestExcludedNoGitignore(c *C) {
f := fixtures.ByTag("empty").One()
r := s.NewRepository(f)

fs := memfs.New()
w := &Worktree{
r: r,
Filesystem: fs,
}

_, err := fs.Open(".gitignore")
c.Assert(err, Equals, os.ErrNotExist)

w.Excludes = make([]gitignore.Pattern, 0)
w.Excludes = append(w.Excludes, gitignore.ParsePattern("foo", nil))

err = util.WriteFile(w.Filesystem, "foo", []byte("FOO"), 0755)
c.Assert(err, IsNil)

status, err := w.Status()
c.Assert(err, IsNil)
c.Assert(status, HasLen, 0)

file := status.File("foo")
c.Assert(file.Staging, Equals, Untracked)
c.Assert(file.Worktree, Equals, Untracked)
}

func (s *WorktreeSuite) TestAddModified(c *C) {
fs := memfs.New()
w := &Worktree{
Expand Down