Error when pushing to an AWS CodeCommit repo (offset deltas are not supported)

[bashims]

We are trying to use go-git to interact with AWS' CodeCommit over HTTPS. After figuring out the auth portion I ran into the following errors when pushing to the repo:

'unpack error: protocol error (offset deltas are not supported)'

and the push failed. I am working on a PR that addresses this issue by using RefDeltas instead of OFSDeltas on push.

[bashims]

Of note I am using v4.6.0

[smola]

Thanks for the report @bashims. We should definitely support ref-deltas on push. If you are doing a PR, keep in mind that switching to ref-deltas should only be done if the server has no ofs-delta capability.

[bashims]

Hi @smola,

I will definitely add the capability check to my patch.

Thanks,

-ben

[bashims]

I submitted #952 for this enhancement.

[smola]

Fixed in #987

[WhileLoop]

@smola
I am getting

reference delta not found

When doing PlainClone on Code Commit.

[nthj]

@WhileLoop I'm seeing the same thing with PlainClone on Code Commit. It works a fair bit of the time. Possible that a force push to master triggered this error, for me?
I'm rm -rfing my tmp/ directory before I try to PlainClone, so I don't think it's any kind of caching issue.

[nthj]

	os.RemoveAll("/tmp/repository")

	_, err := git.PlainClone("/tmp/repository", false, &git.CloneOptions{
		Auth: &githttp.BasicAuth{
			Username: os.Getenv("AWS_ACCESS_KEY_ID") + "%" + os.Getenv("AWS_SESSION_TOKEN"),
			Password: getRepositoryPassword(),
		},
		Depth:         1,
		Progress:      nil,
		ReferenceName: getReferenceName(reference), // returns "ref/heads/master" in the failing instance
		SingleBranch:  true,
		Tags:          git.NoTags,
		URL:           getRepositoryURL(),
	})

	// results in "reference delta not found", sometimes
	check(err)
}

Edit: perhaps worth noting I only see this when I configure ReferenceName. If I leave that option off, it always works.

Edit 2: Ah, maybe not. Now it's triggering even without ReferenceName being configured

Edit 3: Destroying and recreating the Code Commit repository "fixed" it. I'm going to avoid force-pushing to master and see if it still ends up reproducing itself.

[smola]

Moving to #1032
Since this appears to be a different issue.