Skip to content

chroot: allow Symlinks cross boundary #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2017
Merged

chroot: allow Symlinks cross boundary #38

merged 1 commit into from
Jun 26, 2017

Conversation

mcuadros
Copy link
Contributor

This PR allows the creation of links where the target is outside of the chroot. The downside is that the file can be read it, not being a strict chroot anymore.

Fixes src-d/go-git#445

@mcuadros mcuadros requested a review from smola June 24, 2017 08:48
@codecov
Copy link

codecov bot commented Jun 24, 2017

Codecov Report

Merging #38 into master will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #38      +/-   ##
=========================================
+ Coverage   86.47%   86.9%   +0.42%     
=========================================
  Files           8       8              
  Lines         658     649       -9     
=========================================
- Hits          569     564       -5     
+ Misses         56      54       -2     
+ Partials       33      31       -2
Impacted Files Coverage Δ
helper/chroot/chroot.go 89.91% <ø> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74cbe6...8cde47a. Read the comment docs.

@mcuadros mcuadros merged commit 1801347 into src-d:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants