internal/function: use custom fixed struct as LOC result #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
Jul 12, 2019
docs/using-gitbase/examples.md
Outdated
| @@ -81,9 +81,9 @@ GROUP BY committer_email, | |||
| ```sql | |||
| SELECT | |||
| LANGUAGE(file_path, blob_content) as lang, | |||
| SUM(JSON_EXTRACT(LOC(file_path, blob_content), '$.Code')) as code, | |||
There was a problem hiding this comment.
I would say to do the opposite, keep output as it was. Also, other functions have keys with first letter uppercase too.
There was a problem hiding this comment.
Using uppercase is a bit weird in JSON, hence #930
If we do want to use uppercase, though, I can close the issue and change it back here.
There was a problem hiding this comment.
I'm concerned about backward compatibility. All queries that are using these functions will stop working with no error message...
erizocosmico
force-pushed
the
fix/loc-fixed-result
branch
from
d5a5964 to
1a89332
Compare
|
Struct tags are now uppercase. Docs added with the shape of LOC. |
ajnavarro
reviewed
Jul 29, 2019
ajnavarro
reviewed
Jul 29, 2019
Signed-off-by: Miguel Molina <[email protected]>
erizocosmico
force-pushed
the
fix/loc-fixed-result
branch
from
1a89332 to
499c7d5
Compare
|
Done |
ajnavarro
approved these changes
Jul 29, 2019
juanjux
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927
make upgradecommand if applicable.