Skip to content

vendor: upgrade go-mysql-server #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

vendor: upgrade go-mysql-server #804

merged 1 commit into from
Apr 25, 2019

Conversation

erizocosmico
Copy link
Contributor

Closes #799

@erizocosmico erizocosmico requested a review from a team April 23, 2019 12:18
@erizocosmico
Copy link
Contributor Author

Don't merge, there is a regression.

@erizocosmico erizocosmico mentioned this pull request Apr 23, 2019
Closed
@erizocosmico
Copy link
Contributor Author

I'm gonna keep this blocked until HAVING is merged, which fixed a regression as well.

@erizocosmico erizocosmico mentioned this pull request Apr 24, 2019
Closed
@erizocosmico
Copy link
Contributor Author

Ready to be merged

@ajnavarro
Copy link
Contributor

@erizocosmico I think you will need to update go-vitess dependency

@erizocosmico
Copy link
Contributor Author

Should be fixed now. dep didn't notice the update in go-mysql-server without adding a new override for go-vitess.

@erizocosmico
Copy link
Contributor Author

Delaying this again to squeeze src-d/go-mysql-server#697 in

@erizocosmico
vendor: upgrade go-mysql-server
9c3abb4 
Signed-off-by: Miguel Molina <[email protected]>
@erizocosmico
Copy link
Contributor Author

Ready to be merged

@ajnavarro ajnavarro merged commit 5597e48 into src-d:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanjux juanjux juanjux approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@kuba-- kuba-- kuba-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table "commits" does not have column "repository_id"
4 participants
@erizocosmico @ajnavarro @juanjux @kuba--