rule: parallelize projects calling UAST not under exchanges #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
reviewed
Mar 29, 2019
There was a problem hiding this comment.
Tests are failing (generally after upgrading mysql), because in Gopkg.toml we still have:
[[override]]
name = "github.com/moovweb/rubex"
branch = "go1"
where mysql and enry uses go-oniguruma:
github.com/src-d/go-oniguruma v1.0.0
| return nil, io.EOF | ||
| } | ||
|
|
||
| if i.rows == nil { |
There was a problem hiding this comment.
I think we need to wrap this if by mutex
There was a problem hiding this comment.
Nope, Next is never used in parallel
Fixes #766 Since rows are iterated serially (except for exchange nodes), when a Project node calls UAST, it's processed one at a time, which underutilizes the resources in the machine. When a Project calls UAST or UAST_MODE and is not under an Exchange node, which already parallelizes its children, replaces the project with a special node called parallelProject, which is essentially a project that keeps up to N goroutines processing rows, where N is the parallelism value of gitbase. Signed-off-by: Miguel Molina <[email protected]>
|
Should be passing now |
kuba--
approved these changes
Apr 2, 2019
|
Let's keep this on pause after the new fixed RC |
|
@erizocosmico Does the parallel project alter row order? If it does, it can give wrong results if ran after an ORDER BY. |
|
@smola yes, you're right. It needs to check if it has an order by underneath and not execute it in parallel in that case or return the rows in the same order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
Since rows are iterated serially (except for exchange nodes), when
a Project node calls UAST, it's processed one at a time, which
underutilizes the resources in the machine.
When a Project calls UAST or UAST_MODE and is not under an Exchange
node, which already parallelizes its children, replaces the project
with a special node called parallelProject, which is essentially a
project that keeps up to N goroutines processing rows, where N is
the parallelism value of gitbase.
Signed-off-by: Miguel Molina [email protected]