*: implement indexable interfaces on basic and relation tables #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarmonaa
changed the title
|
Needs rebase |
mcarmonaa
force-pushed
the
feature/add-indexable-interfaces
branch
from
634ce9b to
75cbd94
Compare
|
@erizocosmico, rebased! |
mcarmonaa
force-pushed
the
feature/add-indexable-interfaces
branch
from
75cbd94 to
1c7bc36
Compare
mcarmonaa
force-pushed
the
feature/add-indexable-interfaces
branch
2 times, most recently
from
2f76990 to
4004d38
Compare
mcarmonaa
changed the title
mcarmonaa
changed the title
|
@mcarmonaa @ajnavarro since as of #295 the indexes are going to work with If there's something reusable from this PR, it should be updated now that all its dependencies have been merged and merged to master or a branch to start working from this. |
|
@erizocosmico yeah, maybe we should get as much as we can from this PR, and define the new index values per table. |
|
Ok, will merge this in another branch and then go from here. |
erizocosmico
force-pushed
the
feature/add-indexable-interfaces
branch
from
4004d38 to
62d5848
Compare
Signed-off-by: Manuel Carmona <[email protected]>
This was referenced Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on [src-d/go-mysql-server] PRs:
sql/analyzer: resolve correctly GetField expressions indexes go-mysql-server#181, until this is merged, the
go-mysql-serverdependency can't be updated because of tests failing. Also here is implemented the methodIndexOffor the schema which is used by theIndexKeyValueItermethodsql/plan: return a new instance of sql.Row in cross join iterator's next method go-mysql-server#206, until this is merged, the
go-mysql-serverdependency can't be updated because of tests failing.sql: Add *sql.Context to Indexable interface's methods go-mysql-server#193, in this PR
sql.Contextis added to thesql.Indexableinterfaces. This change is needed to have access to the repository pool from thesql.Indexablemethods implementation.@src-d/data-retrieval just have a look to the proposed implementation, if all is ok I'll address the dependency update.
Signed-off-by: Manuel Carmona [email protected]