Code viewer #62
Merged
Code viewer #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosms
reviewed
Jun 6, 2018
frontend/src/App.js
Outdated
| showModal: true, | ||
| modalTitle: 'UAST', | ||
| modalContent: | ||
| // currently github returns only 1 item, UAST of the file |
|
The only minor thing I see is how the modal overflows. As you can see in the screenshot, the vertical scroll is on the modal, while the horizontal is for the code component. If it makes sense, please consider changing this so both scrolls apply to the code component.
|
|
Your suggestion makes perfect sense! The bottom scrollbar is kind of invisible on Mac so I missed it. Fixed. |
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #47
Based on #52, #60
This PR doesn't implement syntax highlighting in editor. It requires changes to code detection (move from FE to BE) and language guessing using envy. It will be implemented in another issue: #61