Skip to content

Use go-cli, add version/serve subcommands #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Conversation

carlosms
Copy link
Contributor

@carlosms carlosms commented Oct 1, 2018

Fix #244.

Using go-cli, now the command looks like this:

$ ./gitbase-web version
gitbase-web version dev-c9b1196-dirty build 10-01-2018_17_06_22

$ ./gitbase-web serve -h
Usage:
  gitbase-web [OPTIONS] serve [serve-OPTIONS]

starts serving the application

Help Options:
  -h, --help              Show this help message

[serve command options]

...

@carlosms carlosms requested a review from smola October 1, 2018 15:10
Copy link

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I tried finding a way to add default commands cleanly (so that we can have no subcommands and --version) to go-cli, but didn't find it yet.

@carlosms carlosms merged commit e5a5259 into src-d:master Oct 2, 2018
@carlosms
Copy link
Contributor Author

carlosms commented Oct 2, 2018

Yeah, I'd prefer to skip the subcommand. But I guess it also makes sense for the sake of consistency if all our bins have binname version, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants