Fix handling of rate limit by checking response headers in transport #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lou Marvin Caraig <[email protected]>
se7entyse7en
force-pushed
the
rate-limiter-fix
branch
from
b9ec831 to
7dadac6
Compare
smacker
reviewed
Jun 26, 2019
|
Does it make sense to have tests for it? Or will it be completely mocked, and we won't be really testing much...? |
I'd open an issue for this to decide also how to test, and this should also be part of the testing design doc. I guess that the main point is whether we want to mock or use a fake org. Even if we decide to mock, this feature would be tested anyway if we're able to assert that the sleep occurs. |
Signed-off-by: Lou Marvin Caraig <[email protected]>
smacker
approved these changes
Jun 28, 2019
|
Opened issue #53 for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
This fixes the rate limiter by checking the response headers and sleeping after the last remaining request has been done. See the issue for details.