Skip to content

Prepare Production, and make Staging private #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2018
Merged

Prepare Production, and make Staging private #236

merged 3 commits into from
Apr 9, 2018

Conversation

dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Apr 4, 2018 •
edited
Loading

After preparing Production environment #218 , some other changes must be done to:

@dpordomingo dpordomingo added the enhancement Improvements are needed over an existent feature label Apr 4, 2018
@dpordomingo dpordomingo self-assigned this Apr 4, 2018
dpordomingo
dpordomingo commented Apr 4, 2018
View reviewed changes
Copy link
Contributor Author

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rporres PTAL

.drone.yml
@@ -97,6 +97,6 @@ pipeline:
<<: *helm_deploy
prefix: PROD
secrets: [ PROD_API_SERVER, PROD_KUBERNETES_TOKEN ]
values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.sourced.tech,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround
values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.srcd.run,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this conf compatible @rporres ?

ingress.globalStaticIpName=code-annotation-production
ingress.hostname=code-annotation.srcd.run

I'm not sure if we should use a new globalStaticIpName suffixed as -production while we're having a hostname following the staging pattern.

Is this something I should care about?
Does it affect the place where you store the secrets and these configurations?
(most probably I'm mixing concepts, so please ping me when you have time to explain it to me irl 💃 )

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use code-annotation-production.srcd.run as hostname. The rest is ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's the hostname defined by @mcuadros in the GH OAuth App as he wrote at #217 (comment)

Should we ask him to change it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'oh, ok. I don't like that name, but I guess it's late to change it. I will change it on my side...

@dpordomingo dpordomingo requested review from rporres and bzz April 4, 2018 19:54
@dpordomingo dpordomingo mentioned this pull request Apr 4, 2018
Closed
bzz
bzz approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@bzz bzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for @rporres feedback as well.

Only App team members will be able to login to staging now.

I guess we just need to make sure that on production, same users as before would be able to log in, and see their previous answers.

@dpordomingo
Copy link
Contributor Author

Since the staging DB will be copied to production, all workers will keep their previous work already done in Staging.
The Production ACL will be the same as currently in Staging: restrictAccessGroup:org:src-d, so nothing changed about it in Prod.

Does it answer your questions @bzz ?

@dpordomingo dpordomingo changed the base branch from release/v0.0.8 to release/v0.1 April 6, 2018 13:09
@dpordomingo dpordomingo mentioned this pull request Apr 6, 2018
Merged
rporres
rporres suggested changes Apr 9, 2018
View reviewed changes
.drone.yml
@@ -97,6 +97,6 @@ pipeline:
<<: *helm_deploy
prefix: PROD
secrets: [ PROD_API_SERVER, PROD_KUBERNETES_TOKEN ]
values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.sourced.tech,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround
values: ingress.globalStaticIpName=code-annotation-production,ingress.hostname=code-annotation.srcd.run,image.tag=${DRONE_TAG},deployment.gaTrackingID=UA-109494282-2,secretName=code-annotation-drone-workaround
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use code-annotation-production.srcd.run as hostname. The rest is ok

@dpordomingo dpordomingo changed the title [RFC] Prepare Production, and make Staging private Prepare Production, and make Staging private Apr 9, 2018
@dpordomingo dpordomingo merged commit f734b55 into src-d:release/v0.1 Apr 9, 2018
@dpordomingo dpordomingo deleted the staging-close branch April 9, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rporres rporres rporres approved these changes

@bzz bzz bzz approved these changes

Assignees

@dpordomingo dpordomingo

Labels
enhancement Improvements are needed over an existent feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpordomingo @rporres @bzz