update go-git to latest version for performance improvements #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 69.73% 69.73%
=======================================
Files 11 11
Lines 935 935
=======================================
Hits 652 652
Misses 214 214
Partials 69 69Continue to review full report at Codecov.
|
ajnavarro
approved these changes
Aug 29, 2017
mcarmonaa
reviewed
Aug 29, 2017
glide.yaml
Outdated
| @@ -12,7 +12,7 @@ import: | |||
| version: 763351934333e34370292b308c74bcb71035e22a | |||
| repo: https://github.com/src-d/go-billy-siva.git | |||
| - package: gopkg.in/src-d/go-git.v4 | |||
| version: 773841734e11f0f607f6b047235f8527d475538f | |||
| version: 7aa9d15d395282144f31a09c0fac230da3f65360 | |||
There was a problem hiding this comment.
Since this commit is tagged in go-git as "v4.0.0-rc14", maybe it's better use the tag name instead the commit here so you can see which go-git version is being used at a glance.
What do you think?
There was a problem hiding this comment.
I'm not sure if the tag is reachable from gopkg.in
mcarmonaa
approved these changes
Aug 29, 2017
erizocosmico
force-pushed
the
update-go-git
branch
from
de56a11 to
b92575a
Compare
This was referenced Aug 29, 2017
bzz
approved these changes
Aug 29, 2017
|
Don't merge til we update it to have src-d/go-git#569 |
Signed-off-by: Miguel Molina <[email protected]>
erizocosmico
force-pushed
the
update-go-git
branch
from
b92575a to
af23d16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.