logging: propagate logger instance and context #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 65.9% 66.27% +0.37%
==========================================
Files 11 11
Lines 871 845 -26
==========================================
- Hits 574 560 -14
+ Misses 236 221 -15
- Partials 61 64 +3
Continue to review full report at Codecov.
|
ajnavarro
suggested changes
Jul 18, 2017
archiver.go
Outdated
|
|
||
| gr, err := a.TemporaryCloner.Clone(j.RepositoryID.String(), endpoint) | ||
| if err != nil { | ||
| if err == transport.ErrRepositoryNotFound { |
| return ResolveCommit(r, o.Target) | ||
| default: | ||
| log.Warn("referenced object not supported", "type", o.Type()) | ||
| log15.Warn("referenced object not supported", "hash", h.String(), "type", o.Type()) |
Contributor
There was a problem hiding this comment.
this log is missing the context too, right?
Contributor
Author
There was a problem hiding this comment.
Right, the way it is structured right now, this function doesn't get context. We might want to fix in a future PR?
Contributor
|
@smola did you have a chance to have a look to this PR? |
Contributor
|
@smola ping |
Contributor
Author
|
@ajnavarro pong ;) |
ajnavarro
approved these changes
Aug 1, 2017
* Remove notifiers: we used them only for logging, and we did not remove logger usage with them anyway. * Propagate logger instances (no global logger) and defined context. Since we never define a global logger, and only the main entry point instantiates a logger from scratch, it's harder to miss propagating the right context in the logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not remove logger usage with them anyway.
This improves log message by ensuring proper context fields are
not missing.