Merged
Conversation
casperstorm
force-pushed
the
pop-typying-style
branch
from
8be6c68 to
e5e070f
Compare
andymandias
approved these changes
Apr 1, 2026
Collaborator
andymandias
left a comment
andymandias
left a comment
There was a problem hiding this comment.
Looks good! Made some minor changes to get channel and query buffers to have a more consistent look.
I don't really have a sense which style would be more popular, but I think popped is a bit more common than padded so I think it's the right default?
…r displaying the typing indicator).
casperstorm
force-pushed
the
pop-typying-style
branch
from
4ea6654 to
69c4de3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
styletotypingwith two variants:poppedandpadded.