Add a read only subscript to ObservableModel
#358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjohnson12
approved these changes
Jul 15, 2025
|
i think a reasonable test for this would just be an example that previously did not compile, but then does after the change |
|
for visibility, i believe this is the issue we ran into: swiftlang/swift#56385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://square.slack.com/archives/CBZJ5V163/p1751313246347059
UI-8947
When you have a screen with a model type of
ActionModel<MyWorkflow.State, MyWorkflow.Action>, you were unable to use aletor computedvarproperty on your state model, and reference it on that screen. If you did you would get a compiler error ofCannot assign to property: 'enableDoneButton' is a 'let' constant, even if you were only trying to read the property.Checklist
ObservableModelin the codebase currently. As I'm not very familiar with this codebase, I don't know how to really make a useful test here.