[fix]: resolve memory exclusivity violations in some WorkflowObserver paths #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
changed the title
jamieQ
commented
May 22, 2023
| /// - isExternal: Whether the handled action came from the 'outside world' vs being bubbled up from a child node | ||
| /// - Returns: An optional `Output` produced by the action application | ||
| func openAndApply<A: WorkflowAction>( | ||
| _ action: A, | ||
| to state: inout WorkflowType.State, |
There was a problem hiding this comment.
the diff makes this a bit confusing, but removing this parameter just means that self.state is no longer shadowed in this method
amorde
approved these changes
May 22, 2023
square-tomb
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
inoutparameter to resolve the problemChecklist