Conditionally conform AdaptedEnvironmentScreen to Screen, based on its content #198
Conversation
| @@ -30,7 +30,7 @@ import ViewEnvironment | |||
| /// .adaptedEnvironment(keyPath: \.myValue, to: newValue) | |||
| /// ``` | |||
| /// | |||
| public struct AdaptedEnvironmentScreen<Content: Screen>: Screen { | |||
There was a problem hiding this comment.
thinking out loud: this change just makes things more permissive – you can now adapt any content type, not just screens (in practice would this be some form of Element?).
There was a problem hiding this comment.
I'll defer to @bencochran here since he's the one who usually structures things this way, but eg, it's common to build a back stack wrapping some type of view model, etc, and then map that into a screen type after you fetch it. This allows you to use environment adaptation alongside that.
| @@ -30,7 +30,7 @@ import ViewEnvironment | |||
| /// .adaptedEnvironment(keyPath: \.myValue, to: newValue) | |||
| /// ``` | |||
| /// | |||
| public struct AdaptedEnvironmentScreen<Content: Screen>: Screen { | |||
| public struct AdaptedEnvironmentScreen<Content> { | |||
| /// The screen wrapped by this screen. | |||
| public var wrapped: Content | |||
There was a problem hiding this comment.
nit: the parameter names & comments now seem slightly mis-matched if the generic type is unconstrained
There was a problem hiding this comment.
I think in reality, this is going to be 99% screens / mapped to one eventually, so I left it as is.
Based on the work done in #106, so that way you can do an adaptation before, eg you map something to a
Screen.Checklist