Pass Rendering if any Conflations changed state #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
zach-klippenstein
approved these changes
Apr 22, 2025
| @@ -1632,6 +1630,90 @@ class RenderWorkflowInTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun for_conflate_and_render_only_when_state_changed_we_do_not_conflate_stacked_actions_into_one_rendering_if_previous_rendering_changed() { | |||
There was a problem hiding this comment.
Couldn't get goose to summarize this paragraph for you? 😜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were short circuiting if the last action handled did not change state - but that's wrong. We cannot short circuit unless all of the actions processed so far have not changed state (otherwise we might not pass the updated Rendering to the UI ever).
Found this in register, added test to red-green repro the scenario.