Cache the AVD in CI before executing any tests #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
background: https://workflow-community.slack.com/archives/CHTFPR277/p1689193974005269 I was using `actions/cache@v3` to restore and possibly save the AVD in instrumented test shards. That basic "cache" action handles both reading and writing to the cache. The writing is done during a post-action, meaning that if the AVD was cached, it was cached *after* it had been used for the instrumented tests. Now, we use the newer `actions/cache/restore@v3` and `actions/cache/save@v3` actions, like we use elsewhere. Now, if there was a cache miss and we have to make a new AVD, it is cached before the tests are executed so that it doesn't have any of our test apps installed.
|
Be sure to hide whitespace when reviewing this! |
rjrjr
approved these changes
Jul 13, 2023
Yeah, sorry about that. This is the style set by |
Well worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background: https://workflow-community.slack.com/archives/CHTFPR277/p1689193974005269
I was using
actions/cache@v3to restore and possibly save the AVD in instrumented test shards.That basic "cache" action handles both reading and writing to the cache. The writing is done during a post-action, meaning that if the AVD was cached, it was cached after it had been used for the instrumented tests.
Now, we use the newer
actions/cache/restore@v3andactions/cache/save@v3actions, like we use elsewhere. Now, if there was a cache miss and we have to make a new AVD, it is cached before the tests are executed so that it doesn't have any of our test apps installed.