Incorrect link in remember-me documentation #1915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrong site link url
|
@umanking Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@umanking Thank you for signing the Contributor License Agreement! |
eleftherias
suggested changes
Sep 13, 2021
There was a problem hiding this comment.
Thanks for bringing this up @umanking.
You are correct that the link is wrong, however, the link that you suggested points to a very old version of Spring Security.
I have included the corrected link in a suggestion below.
Comment on lines
+511
to
+512
|
|
||
| Spring Session provides integration with https://docs.spring.io/spring-security/site/docs/3.0.x/reference/remember-me.html[Spring Security's Remember-me Authentication]. |
There was a problem hiding this comment.
Suggested change
| Spring Session provides integration with https://docs.spring.io/spring-security/site/docs/3.0.x/reference/remember-me.html[Spring Security's Remember-me Authentication]. | |
| Spring Session provides integration with https://docs.spring.io/spring-security/site/docs/{spring-security-version}/reference/html5/#servlet-rememberme[Spring Security's Remember-me Authentication]. |
eleftherias
added
in: docs
|
@umanking Could you please update this PR with the correct link? |
eleftherias
changed the title
|
I have updated the link via beb7b33. Thank you for bringing this to my attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrong site link url