Introduce Spring Session MongoDB. #1901

gregturn · 2021-08-26T17:05:53Z

Migrate the module's code back into this project.
Fold the documentation in.
Update to current Gradle conventions.
Reformat to match styling.

vpavic · 2021-08-27T19:32:19Z

gradle/dependency-management.gradle

 		dependency 'com.h2database:h2:1.4.200'
 		dependency 'com.ibm.db2:jcc:11.5.6.0'
 		dependency 'com.microsoft.sqlserver:mssql-jdbc:9.4.0.jre8'
 		dependency 'com.oracle.database.jdbc:ojdbc8:21.1.0.0'
 		dependency 'com.zaxxer:HikariCP:3.4.5'
+		dependency 'de.flapdoodle.embed:de.flapdoodle.embed.mongo:2.2.0'


IMO it would be a good idea to use Testcontainers instead of embedded MongoDB for integration testing, for consistency with the rest of the integration tests.

vpavic · 2021-08-27T19:33:37Z

gradle/dependency-management.gradle

@@ -15,11 +16,15 @@ dependencyManagement {
 		}

 		dependency 'org.aspectj:aspectjweaver:1.9.7'
+		dependency 'org.aspectj:aspectjweaver:1.9.6'


This line seems redundant (see one above).

vpavic · 2021-08-27T19:34:20Z

gradle/dependency-management.gradle

 		dependency 'org.hsqldb:hsqldb:2.5.1'
 		dependency 'org.mariadb.jdbc:mariadb-java-client:2.7.4'
 		dependency 'org.mockito:mockito-core:3.11.2'
+        dependencySet(group: 'org.mockito', version: '3.10.0') {


This appears to actually downgrade Mockito version (see one line above).

vpavic · 2021-08-27T19:36:00Z

settings.gradle

@@ -17,6 +17,7 @@ include 'spring-session-data-redis'
 include 'spring-session-docs'
 include 'spring-session-hazelcast'
 include 'spring-session-jdbc'
+include 'spring-session-mongodb'


This should be spring-session-data-mongodb, meaning the code should also reallocate to the equally named directory.

vpavic · 2021-08-27T19:40:04Z

spring-session-docs/src/docs/asciidoc/index.adoc

@@ -140,13 +148,11 @@ While convenient, this approach was not sustainable long-term as more features a

 Starting with Spring Session 2.0, the project has been split into Spring Session Core module and several other modules that carry `SessionRepository` implementations and functionality related to the specific data store.
 Users of Spring Data should find this arrangement familiar, with Spring Session Core module taking a role equivalent to Spring Data Commons and providing core functionalities and APIs, with other modules containing data store specific implementations.
-As part of this split, the Spring Session Data MongoDB and Spring Session Data GemFire modules were moved to separate repositories.
+As part of this split, the Spring Session Data GemFire module was moved to a separate repository.


IMO the entire Spring Session Modules chapter should be rewritten, and this specific paragraph (that is focused on what happened in 2.0) removed. Changing this sentence alone but not the context around it is both misleading and incorrect.

vpavic · 2021-08-27T19:40:45Z

spring-session-mongodb/pom.xml

@@ -0,0 +1,986 @@
+<?xml version="1.0" encoding="UTF-8"?>


I guess this pom.xml isn't needed.

vpavic · 2021-08-27T19:43:58Z

spring-session-mongodb/spring-session-mongodb.gradle

+
+	optional "org.mongodb:mongodb-driver-core"
+	testCompile "org.mongodb:mongodb-driver-sync"
+	testCompile ("de.flapdoodle.embed:de.flapdoodle.embed.mongo") {


As mentioned in one of the earlier comments, IMO it would be a good idea to use Testcontainers instead of embedded MongoDB for integration testing, for consistency with the rest of the integration tests.

Additionally, the tests should also be split to two source sets - (default) one for unit tests and an additional one for integration tests.

vpavic · 2021-08-27T19:45:23Z

spring-session-mongodb/src/main/asciidoc/index.adoc

@@ -0,0 +1,139 @@
+


This should probably go into spring-session-docs subproject.

gregturn · 2021-09-07T17:05:25Z

Things @vpavic for checking out my PR. I'll make changes.

gregturn · 2021-09-07T18:27:16Z

I've applied all the changes requested @vpavic. I squashed them together. Feel free to offer more comments.

vpavic · 2021-09-07T21:09:27Z

Hey @gregturn, I'll try to take another look at this by the end of the week.

* Migrate the module's code back into this project. * Fold the documentation in. * Update to current Gradle conventions. * Reformat to match styling.

eleftherias

@gregturn I added commits to rebase on main and update the documentation to use Antora.
I also fixed the samples, I added an inline comment about the change that I made, let me know if you prefer an alternative approach.

eleftherias · 2021-10-11T15:00:00Z

...ring-session-sample-boot-mongodb-reactive/spring-session-sample-boot-mongodb-reactive.gradle

+	compile "org.springframework.boot:spring-boot-starter-webflux"
+	compile "org.springframework.boot:spring-boot-starter-thymeleaf"
+	compile "org.springframework.boot:spring-boot-starter-data-mongodb-reactive"
+    compile "de.flapdoodle.embed:de.flapdoodle.embed.mongo"


I added an embedded MongoDB to both samples.
The alternative is to expect the user to have a local MongoDB instance on their machine before running the sample. In that case we would need to update the integration tests for the samples to use test containers.

eleftherias · 2021-10-20T10:04:46Z

Merged via bf139db

Issue gh-1901

gregturn requested a review from eleftherias August 26, 2021 17:05

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 26, 2021

vpavic reviewed Aug 27, 2021

View reviewed changes

gregturn force-pushed the issue/spring-session-data-mongodb branch from 7d3fb7d to 94e4163 Compare September 7, 2021 18:26

vpavic self-requested a review September 7, 2021 21:09

eleftherias added type: enhancement A general enhancement in: mongo-db and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2021

gregturn and others added 4 commits October 11, 2021 16:21

Introduce Spring Session MongoDB.

6d04fa8

* Migrate the module's code back into this project. * Fold the documentation in. * Update to current Gradle conventions. * Reformat to match styling.

Fix formatting

98e991b

Move Mongo docs to Antora

01caa14

Add embedded mongo server to samples

2ba58f2

eleftherias force-pushed the issue/spring-session-data-mongodb branch from 94e4163 to 2ba58f2 Compare October 11, 2021 14:40

eleftherias reviewed Oct 11, 2021

View reviewed changes

Merge branch 'main' into issue/spring-session-data-mongodb

84eb163

eleftherias closed this Oct 20, 2021

eleftherias self-assigned this Oct 20, 2021

eleftherias added this to the 2.6.0-RC2 milestone Oct 20, 2021

eleftherias added a commit that referenced this pull request Nov 26, 2021

Update README to include MongoDB

1eb53ea

Issue gh-1901

eleftherias added a commit that referenced this pull request Jan 14, 2022

Update README to include MongoDB

88e213d

Issue gh-1901

gregturn deleted the issue/spring-session-data-mongodb branch April 14, 2022 14:28

Introduce Spring Session MongoDB. #1901

Introduce Spring Session MongoDB. #1901

Uh oh!

Conversation

gregturn commented Aug 26, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gregturn commented Sep 7, 2021

Uh oh!

gregturn commented Sep 7, 2021

Uh oh!

vpavic commented Sep 7, 2021

Uh oh!

eleftherias left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eleftherias commented Oct 20, 2021

Uh oh!

Uh oh!