-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triagedtype: bugA general bugA general bug
Description
Describe the bug
After changeSessionId
, expirationStore(ordered set) lost the new sessionId
To Reproduce
- config
SortedSetRedisSessionExpirationStore
for expirationStore - Create a new session and save it
- FindById to get the previously saved session
- Call changeSessionId and save it
- You can see in the
expiration
kv of redis that the new sessionId does not exist
Expected behavior
The old sessionId should be deleted and the new sessionId should be appended to the sorted set of redis
Source
Line 994 in 2353d8b
RedisIndexedSessionRepository.this.expirationStore.remove(this.originalSessionId); |
How to fix
We can add a rename method to the RedisSessionExpirationStore
interface
rename(String oldSessionId, String newSessionId, Integer expirationInMillis)
Metadata
Metadata
Assignees
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triagedtype: bugA general bugA general bug