Fixed broken link #6522
Closed
Fixed broken link #6522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwinch
added
in: docs
|
Thanks for the PR @rhamedy! This is merged via 43587b4 PS: I changed the commit message to include that it fixes the issue you logged to follow our conventions. See the commit message to align with the Spring Security conventions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6521
Summary: Updated the Pull Request link in the README.adoc to point to the correct Github article https://help.github.com/articles/creating-a-pull-request instead of https://help.github.com/send-pull-requests which is broken.
This link https://docs.spring.io/spring-security/site/docs/current/apidocs/ under https://github.com/spring-projects/spring-security/blob/master/README.adoc#documentation as Spring Security API Documentation is also broken. Added the correct URL https://docs.spring.io/spring-security/site/docs/current/api/
Also noticed that the initial PR had nickname instead of full name. I also squashed the commits to 1.