Provide AuthenticatedPrincipal abstraction #4268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Spring IO Athens-BUILD-SNAPSHOT -> Cairo-BUILD-SNAPSHOT * CGLib 3.1 -> 3.2.5 latest release Issue related to ASM cglib/cglib#20 * AssertJ 2.2.0 -> 3.6.2 latest release * PowerMock 1.6.2 -> 1.6.5 latest release is 1.6.6 but has regression Issue powermock/powermock#717 * Update maven-compiler-plugin source/target to 1.8
jgrandja
force-pushed
the
named-principal
branch
from
963231c to
b5496f3
Compare
rwinch
reviewed
Apr 10, 2017
| * | ||
| * @return the identifier for the authenticated <code>Principal</code> | ||
| */ | ||
| String getId(); |
There was a problem hiding this comment.
We don't need an id, so we shouldn't have it
There was a problem hiding this comment.
getId() has been removed
|
Thanks...that's all the feedback I had. Given we discussed the id and you agreed go ahead and make that change and then you can merge :) |
jgrandja
changed the title
jgrandja
force-pushed
the
named-principal
branch
from
b5496f3 to
71e491f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal for the
AuthenticatedPrincipalabstraction is to decouplePrincipaltype of abstractions fromAbstractAuthenticationToken, specificallyAbstractAuthenticationToken.getName().As of now we are referencing
UserDetailsinAbstractAuthenticationToken.getName()and it would be nice to abstract this away to a generic interface that would provide the name of thePrincipalfor any representation of aPrincipal, for example,UserDetails, OAuth2 User, OpenID Connect User, etc.