Fix updateClusterId logic #4027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change condition from != null to == null to only fetch clusterId when it's not already set. This avoids unnecessary broker calls and improves performance while maintaining consistency with clusterId() method Signed-off-by: Choi Wang Gyu <[email protected]>
artembilan
reviewed
Jul 28, 2025
| @@ -300,7 +301,7 @@ public final boolean initialize() { | |||
| private void updateClusterId(Admin adminClient) throws InterruptedException, ExecutionException, TimeoutException { | |||
| try { | |||
| this.clusterIdLock.lock(); | |||
| if (this.clusterId != null) { | |||
| if (this.clusterId == null) { | |||
There was a problem hiding this comment.
The original change is this: c84d0f7.
According to its logic this indeed has to be == null.
So, i treat this as a simple omission and schedule for back-port.
Thank you for spotting and fixing!
spring-builds
pushed a commit
that referenced
this pull request
Jul 28, 2025
Fixed: #4027 Change condition from `!= null` to `== null` to only fetch `clusterId` when it's not set yet. This avoids unnecessary broker calls and improves performance while maintaining consistency with `clusterId()` method This is a fix for an important omission after #2859 Signed-off-by: Choi Wang Gyu <[email protected]> (cherry picked from commit 052bed7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change condition from != null to == null to only fetch clusterId
when it's not already set.
This avoids unnecessary broker calls and improves
performance while maintaining consistency with clusterId() method