Skip to content

Altered the example in EmbeddedKafkaHolder usage #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Altered the example in EmbeddedKafkaHolder usage #3929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions spring-kafka-docs/src/main/antora/modules/ROOT/pages/testing.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,21 +162,20 @@ public final class EmbeddedKafkaHolder {

public static EmbeddedKafkaBroker getEmbeddedKafka() {
if (!started) {
try {
embeddedKafka.afterPropertiesSet();
}
catch (Exception e) {
throw new KafkaException("Embedded broker failed to start", e);
}
started = true;
synchronized (this) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine. But, don't you think using a lock might be better here since synchronized may have issues with virtual threads?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fully fine.
Just doc. Plus this is intended only for testing.
There is also a fix in Java 24 for synchronized and pinning from virtual threads: https://openjdk.org/jeps/491

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @artembilan. The synchronized block no longer pins the OS thread, so I do not think that is an issue

if (!started) {
try {
embeddedKafka.afterPropertiesSet();
}
catch (Exception e) {
throw new KafkaException("Embedded broker failed to start", e);
}
started = true;
}
}
}
return embeddedKafka;
}

private EmbeddedKafkaHolder() {
super();
}

}
----

Expand Down