Skip to content

Conversation

artembilan
Copy link
Member

Use a dependencyManagement for those projects which bring BOMs

Use a `dependencyManagement` for those projects which bring BOMs
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit-pick

build.gradle Outdated
@@ -15,10 +15,10 @@ plugins {
id 'project-report'
id 'idea'
id "org.sonarqube" version '2.7.1'
id 'org.asciidoctor.convert' version '1.6.1'
id "org.asciidoctor.convert" version '2.3.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why single to double here but double to single below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste artefact: https://plugins.gradle.org/plugin/org.asciidoctor.convert

Although, I agree that I've changed the version template, but missed the name.

Shame on me.

Any other observation in this change?
Any objections at all?

I've just noticed that with BOM for JUnit we don't need to manage version for platform, as well as for Reactor Kafka.

If this is OK, I'll go ahead and fix similar way AMQP and SI
I don't see reason (yet) in managing all the dependency versiona in this section to avoid templating in the target sub-projects as it is done in SF: https://github.com/spring-projects/spring-framework/blob/master/build.gradle#L41

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me.

@garyrussell garyrussell merged commit 9d6628b into spring-projects:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants