GH-9428: Emit MQTT delivery events even if share client instance #9435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instance Fixes: spring-projects#9428 Issue link: spring-projects#9428 When `ClientManager` is used for MQTT channel adapters, a `MqttMessageDeliveredEvent` is not emitted since callback for the `ClientManager` is not aware about `deliveryComplete` * Use a `MqttActionListener` abstraction for the `publish` operation instead of a `deliveryComplete` from a common callback * Make some other refactoring into the `MqttPahoMessageHandler` and `Mqttv5PahoMessageHandler` extracting a common logic into their `AbstractMqttMessageHandler` superclass * Introduce an `MqttMessageNotDeliveredEvent` to be emitted from the `MqttActionListener.onFailure()` callback * Adapt mocks in the `MqttAdapterTests` for a new code flow * Add delivery events verification into the `ClientManagerBackToBackTests`
Looks like the message can be consumed even before we just emit that `MqttMessageSentEvent`
sobychacko
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9428
Issue link: #9428
When
ClientManageris used for MQTT channel adapters, aMqttMessageDeliveredEventis not emitted since callback for theClientManageris not aware aboutdeliveryCompleteMqttActionListenerabstraction for thepublishoperation instead of adeliveryCompletefrom a common callbackMqttPahoMessageHandlerandMqttv5PahoMessageHandlerextracting a common logic into theirAbstractMqttMessageHandlersuperclassMqttMessageNotDeliveredEventto be emitted from theMqttActionListener.onFailure()callbackMqttAdapterTestsfor a new code flowClientManagerBackToBackTests