Skip to content

Support generics in the JsonToObjectTransformer #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artembilan
Copy link
Member

  • Deprecate JsonObjectMapperAdapter if favor of default methods in
    the JsonObjectMapper
  • Introduce JsonObjectMapper.fromJson(Object, ResolvableType) to
    support generics during deserialization
  • Add JsonHeaders.RESOLVABLE_TYPE header handling for the
    ResolvableType management
  • Add ResolvableType argument into the JsonToObjectTransformer
  • Change the JsonToObjectTransformer logic to consult request message
    headers first
  • Add ResolvableType-based factory method into the Transformers
  • Document the change

@artembilan artembilan added this to the 5.2.M1 milestone Mar 18, 2019
Copy link
Contributor

@garyrussell garyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor issue.

* Deprecate `JsonObjectMapperAdapter` if favor of `default` methods in
the `JsonObjectMapper`
* Introduce `JsonObjectMapper.fromJson(Object, ResolvableType)` to
support generics during deserialization
* Add `JsonHeaders.RESOLVABLE_TYPE` header handling for the
`ResolvableType` management
* Add `ResolvableType` argument into the `JsonToObjectTransformer`
* Change the `JsonToObjectTransformer` logic to consult request message
headers first
* Add `ResolvableType`-based factory method into the `Transformers`
* Document the change
@artembilan artembilan force-pushed the Generics_for_JSON2Object branch from f282dbd to 055f56c Compare March 18, 2019 20:38
@artembilan artembilan requested a review from garyrussell March 18, 2019 20:38
@garyrussell garyrussell merged commit 5421574 into spring-projects:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants