Fix new Sonar smells for MMIH #2795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pay attention, please, how I have fixed |
* Fix complexity smells in the `MessagingMethodInvokerHelper` * Reuse `get()` in the `ZookeeperMetadataStore` in case of `putIfAbsent()` error * Polishing for `ZookeeperMetadataStoreTests` * Fix for `hasUnqualifiedMapParameter` * Fix `findHandlerMethodsForTarget()` complexity
garyrussell
reviewed
Mar 8, 2019
| } | ||
|
|
||
| private boolean isMethodEligible(Method methodToProcess) { | ||
| return !(methodToProcess.isBridge() || // NOSONAR bollean complexity |
artembilan
commented
Mar 8, 2019
| throw new ZookeeperMetadataStoreException("Exception while reading node with key '" + key + "':", | ||
| exceptionDuringGet); | ||
| } | ||
| return get(key); |
There was a problem hiding this comment.
Gary, is this fix OK with you?
Because we would need to back-port it anyway.
There was a problem hiding this comment.
Yes, it looks fine; I'll backport it along with the other bugs in ZK from my Sonar fixes.
|
Looks like I forgot to push the fix you had requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessagingMethodInvokerHelperget()in theZookeeperMetadataStorein case ofputIfAbsent()errorZookeeperMetadataStoreTestshasUnqualifiedMapParameterfindHandlerMethodsForTarget()complexity