Fix new Sonar smells #2768
Fix new Sonar smells #2768
Conversation
* Fix some old Sonar smells as well * Fix Micrometer leaks in the `PollableChannel` when we register meters, but don't remove them.
|
Gary, pay attention, please, what I've done for the Let me know if that is good! Also my opinion: I don't like how Sonar react to our Thanks |
|
Plus forgot to say: we don't remove |
* Remove `throws Exception` from `AbstractMessageHandler.destroy()`
…ceptionAndFallbackToExpressionIfAny()`
| if (!(ex instanceof MessagingException) || | ||
| ((MessagingException) ex).getFailedMessage() == null) { | ||
| runtimeException = new MessageHandlingException(message, text.get(), ex); | ||
| runtimeException = new MessageHandlingException(message, text.get(), | ||
| (ex instanceof IllegalStateException && ex.getCause() != null) ? ex.getCause() : ex); |
There was a problem hiding this comment.
I think this might be a bit of abuse and we might need to introduce our own exception like MessagingMethodInvokerException to be able to let end-user IllegalStateException to bubble as is.
Of course if you agree with the change to the MessagingMethodInvokerHelper...
MetricsCaptorin channelsMeterFacadeinPollableChannelimplementationsMessagingMethodInvokerHelper