Make IOS.setTaskScheduler() as public #2725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make `IntegrationObjectSupport.setTaskScheduler()` as `public` and remove all the overrides for visibility * Fix Sonar smells for all the affected classes
garyrussell
reviewed
Jan 30, 2019
| @@ -125,7 +119,7 @@ protected void onInit() { | |||
| } | |||
|
|
|||
| @Override | |||
| public void destroy() throws Exception { | |||
| public void destroy() { | |||
There was a problem hiding this comment.
We can't do this - breaking change for anyone that has subclassed and implemented destroy().
I suggest we use // NOSONAR TODO: remove throws in 5.2, which removing it from our subclasses.
There was a problem hiding this comment.
OK.
Do we remove from our subclasses now as I did in this PR?
Sorry, if I misunderstood you...
* Revert `throws Exception` for `AbstractEndpoint.destroy()`
|
Is the latest commit OK? |
|
LGTM; let's see if Mr. Travis agrees. |
|
OK. It's green finally! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntegrationObjectSupport.setTaskScheduler()aspublicandremove all the overrides for visibility