INT-4570: Add MessageCollectionCallback for Mongo #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-4570 The `MongoDbOutboundGateway` is intended to be used with the `requestMessage` context, however using a plain `CollectionCallback` we don't have access to the `requestMessage` * Deprecate `CollectionCallback` usage in favor of newly introduced `MessageCollectionCallback` and `message-collection-callback` for XML **Cherry-pick to 5.0.x**
garyrussell
suggested changes
Dec 21, 2018
| @@ -253,6 +253,21 @@ | |||
| </xsd:appinfo> | |||
| </xsd:annotation> | |||
| </xsd:attribute> | |||
| <xsd:attribute name="message-collection-callback" type="xsd:string"> | |||
There was a problem hiding this comment.
Why not make MessageCollectionCallback a sub-interface of CollectionCallback? - Then we don't need any schema/parser changes. Just determine the type in the CTOR. It can still be a FunctionalInterface by overriding the basic doInCollection with a default.
There was a problem hiding this comment.
OK. Let me play with that!
Thanks
`MessageCollectionCallback<T> extends CollectionCallback<T>`
|
OK. Now you have less files to review 😄 |
|
Travis test failures. |
reflection collision
|
So, now it's green. |
garyrussell
approved these changes
Dec 21, 2018
|
Cherry-pick is not clean, unfortunately. |
artembilan
added a commit
that referenced
this pull request
Dec 21, 2018
* INT-4570: Add MessageCollectionCallback for Mongo JIRA: https://jira.spring.io/browse/INT-4570 The `MongoDbOutboundGateway` is intended to be used with the `requestMessage` context, however using a plain `CollectionCallback` we don't have access to the `requestMessage` * Deprecate `CollectionCallback` usage in favor of newly introduced `MessageCollectionCallback` and `message-collection-callback` for XML **Cherry-pick to 5.0.x** * * Remove `message-collection-callback` in favor of `MessageCollectionCallback<T> extends CollectionCallback<T>` * * Rename a new setter to `setMessageCollectionCallback()` to avoid reflection collision # Conflicts: # spring-integration-mongodb/src/main/java/org/springframework/integration/mongodb/outbound/MongoDbOutboundGateway.java # spring-integration-mongodb/src/test/java/org/springframework/integration/mongodb/config/MongoDbOutboundGatewayParserTests.java # spring-integration-mongodb/src/test/java/org/springframework/integration/mongodb/dsl/MongoDbTests.java # spring-integration-mongodb/src/test/java/org/springframework/integration/mongodb/outbound/MongoDbOutboundGatewayTests.java # spring-integration-mongodb/src/test/java/org/springframework/integration/mongodb/rules/MongoDbAvailableTests.java # src/reference/asciidoc/mongodb.adoc
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-4570
The
MongoDbOutboundGatewayis intended to be used with therequestMessagecontext, however using a plainCollectionCallbackwe don't have access to the
requestMessageCollectionCallbackusage in favor of newly introducedMessageCollectionCallbackandmessage-collection-callbackfor XMLCherry-pick to 5.0.x