Allow Functions as Service Activators #2575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix `MessagingMethodInvokerHelper` to extract canonical method for the `Function` and `Consumer` beans * Demonstrate in test how `Function` and `Consumer` can be configured with the Messaging annotations
garyrussell
suggested changes
Oct 2, 2018
|
|
||
| final String methodName; | ||
|
|
||
| if (methodNameToUse == null) { |
There was a problem hiding this comment.
It's not good practice to mutate parameter arguments. Better to leave the argument final (e.g. final String methodNameArg) and then String methodName = methodNameArg.
garyrussell
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessagingMethodInvokerHelperto extract canonical method for theFunctionandConsumerbeansFunctionandConsumercan be configuredwith the Messaging annotations
/CC @markpollack , @olegz